[
https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522624#comment-16522624
]
David Smiley commented on SOLR-5211:
------------------------------------
Feel free to propose a trial patch with such a change. I wonder if your
proposal would be better/worse -- I'm not sure. Note that there are some
external callers that want a Lucene Document from the command as well.
A cursory look at your patch looked fine... and I can see that there is some
awkwardness in conditionally adding the block ID prompting your suggestion to
decouple Document conversion about of the command. Separately in SOLR-12441 I
proposed maybe \_root\_ manipulation should be done in an URP, the one being
added in that issue.
> updating parent as childless makes old children orphans
> -------------------------------------------------------
>
> Key: SOLR-5211
> URL: https://issues.apache.org/jira/browse/SOLR-5211
> Project: Solr
> Issue Type: Sub-task
> Components: update
> Affects Versions: 4.5, 6.0
> Reporter: Mikhail Khludnev
> Assignee: Mikhail Khludnev
> Priority: Major
> Attachments: SOLR-5211.patch, SOLR-5211.patch, SOLR-5211.patch
>
>
> if I have parent with children in the index, I can send update omitting
> children. as a result old children become orphaned.
> I suppose separate \_root_ fields makes much trouble. I propose to extend
> notion of uniqueKey, and let it spans across blocks that makes updates
> unambiguous.
> WDYT? Do you like to see a test proves this issue?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
