[
https://issues.apache.org/jira/browse/LUCENE-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523031#comment-16523031
]
Robert Muir commented on LUCENE-8370:
-------------------------------------
The assert in RandomIndexWriter seems broken to me, given my understanding of
the changes. Its checking that forceMerge(N) really merged to <= N segments,
but the merge policy will no longer due that if it violates the max segment
size, correct?
The other problem is that this only happened in a massive stress test. Seems
like this max segment size might not being randomized properly enough in tests?
If we lower it, more tests will engage these constraints.
> Reproducing
> TestLucene70DocValuesFormat.testSortedSetVariableLengthBigVsStoredFields()
> failure
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-8370
> URL: https://issues.apache.org/jira/browse/LUCENE-8370
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index, general/test
> Reporter: Steve Rowe
> Assignee: Erick Erickson
> Priority: Major
>
> Policeman Jenkins found a reproducing seed for a
> {{TestLucene70DocValuesFormat.testSortedSetVariableLengthBigVsStoredFields()}}
> failure [https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/22320/];
> {{git bisect}} blames commit {{2519025}} on LUCENE-7976:
> {noformat}
> Checking out Revision 8c714348aeea51df19e7603905f85995bcf0371c
> (refs/remotes/origin/master)
> [...]
> [junit4] Suite:
> org.apache.lucene.codecs.lucene70.TestLucene70DocValuesFormat
> [junit4] 2> NOTE: reproduce with: ant test
> -Dtestcase=TestLucene70DocValuesFormat
> -Dtests.method=testSortedSetVariableLengthBigVsStoredFields
> -Dtests.seed=63A61B46A6934B1A -Dtests.multiplier=3 -Dtests.slow=true
> -Dtests.locale=sw-TZ -Dtests.timezone=Pacific/Pitcairn -Dtests.asserts=true
> -Dtests.file.encoding=US-ASCII
> [junit4] FAILURE 23.3s J2 |
> TestLucene70DocValuesFormat.testSortedSetVariableLengthBigVsStoredFields <<<
> [junit4] > Throwable #1: java.lang.AssertionError: limit=4 actual=5
> [junit4] > at
> __randomizedtesting.SeedInfo.seed([63A61B46A6934B1A:6BE93FA35E02851]:0)
> [junit4] > at
> org.apache.lucene.index.RandomIndexWriter.doRandomForceMerge(RandomIndexWriter.java:372)
> [junit4] > at
> org.apache.lucene.index.RandomIndexWriter.getReader(RandomIndexWriter.java:386)
> [junit4] > at
> org.apache.lucene.index.RandomIndexWriter.getReader(RandomIndexWriter.java:332)
> [junit4] > at
> org.apache.lucene.index.BaseDocValuesFormatTestCase.doTestSortedSetVsStoredFields(BaseDocValuesFormatTestCase.java:2155)
> [junit4] > at
> org.apache.lucene.codecs.lucene70.TestLucene70DocValuesFormat.testSortedSetVariableLengthBigVsStoredFields(TestLucene70DocValuesFormat.java:93)
> [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [junit4] > at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [junit4] > at
> java.base/java.lang.reflect.Method.invoke(Method.java:564)
> [junit4] > at java.base/java.lang.Thread.run(Thread.java:844)
> [...]
> [junit4] 2> NOTE: test params are: codec=Asserting(Lucene70): {},
> docValues:{}, maxPointsInLeafNode=693, maxMBSortInHeap=5.078503794479895,
> sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@20a604e6),
> locale=sw-TZ, timezone=Pacific/Pitcairn
> [junit4] 2> NOTE: Linux 4.13.0-41-generic amd64/Oracle Corporation 9.0.4
> (64-bit)/cpus=8,threads=1,free=352300304,total=518979584
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
