Yeah sure was. This was the most thankless bug hunt I can remember because it'll basically never actually occur in production Solr. But we have a failing test so... And the ultimate fix was already known (to me) any way: Don't use SimpleDateFormat. It sucks, I knew it before, and here's more evidence why it does. Yawn. Move on to java.time...
On Thu, Jun 28, 2018 at 1:54 PM Erick Erickson <[email protected]> wrote: > Gnarly! > > On Thu, Jun 28, 2018 at 10:49 AM, David Smiley (JIRA) <[email protected]> > wrote: > > > > [ > https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > > > David Smiley updated SOLR-10243: > > -------------------------------- > > Attachment: SimpleDateFormatTimeZoneBug.java > > > >> Fix TestExtractionDateUtil.testParseDate sporadic failures > >> ---------------------------------------------------------- > >> > >> Key: SOLR-10243 > >> URL: https://issues.apache.org/jira/browse/SOLR-10243 > >> Project: Solr > >> Issue Type: Task > >> Security Level: Public(Default Security Level. Issues are Public) > >> Reporter: David Smiley > >> Assignee: David Smiley > >> Priority: Major > >> Attachments: SimpleDateFormatTimeZoneBug.java > >> > >> > >> Jenkins test failure: > >> {{ant test -Dtestcase=TestExtractionDateUtil > -Dtests.method=testParseDate -Dtests.seed=B72AC4792F31F74B > -Dtests.slow=true -Dtests.locale=lv -Dtests.timezone=America/Metlakatla > -Dtests.asserts=true -Dtests.file.encoding=UTF-8}} It reproduces on 6x > for me but not master. > >> I reviewed this briefly and there seems to be a locale assumption in > the test. > >> 1 tests failed. > >> FAILED: > org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate > >> Error Message: > >> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13 > 04:35:51 AKST 2008) > >> Stack Trace: > >> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 != > 1226579751000 (Thu Nov 13 04:35:51 AKST 2008) > >> at > __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0) > >> at org.junit.Assert.fail(Assert.java:93) > >> at org.junit.Assert.assertTrue(Assert.java:43) > >> at > org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59) > >> at > org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54) > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v7.6.3#76005) > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
