[ 
https://issues.apache.org/jira/browse/LUCENE-8387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534311#comment-16534311
 ] 

Robert Muir commented on LUCENE-8387:
-------------------------------------

As mentioned above, I think a subclass can access the slices already since its 
protected final. Personally I think this is enough. If we are going to add a 
getter than this should be made private, otherwise the javadocs becomes 2x as 
confusing for really no good reason.

adding access to the actual leaves makes sense.

> Add IndexSearcher.getSlices
> ---------------------------
>
>                 Key: LUCENE-8387
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8387
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Major
>         Attachments: LUCENE-8387.patch
>
>
> When you pass an executor to {{IndexSearcher}}, it creates a {{LeafSlice[]}} 
> slices, by default once slice per leaf, but a subclass can override.  It's 
> helpful to later be able to get those slices e.g. if you want to do your own 
> concurrent per-slice processing.
> This patch will just add a getter to {{IndexSearcher}}, and make the 
> {{LeafSlice.leaves}} member public.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to