[
https://issues.apache.org/jira/browse/SOLR-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535456#comment-16535456
]
Lucene/Solr QA commented on SOLR-12516:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} SOLR-12516 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12516 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12930455/SOLR-12516.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/139/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> JSON "range" facets can incorrectly refine subfacets for buckets
> ----------------------------------------------------------------
>
> Key: SOLR-12516
> URL: https://issues.apache.org/jira/browse/SOLR-12516
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Major
> Fix For: master (8.0), 7.5
>
> Attachments: SOLR-12516.patch, SOLR-12516.patch, SOLR-12516.patch,
> SOLR-12516.patch, SOLR-12516.patch, SOLR-12516.patch, SOLR-12516.patch
>
>
> while simple {{type:range}} facets don't benefit from refinement, because
> every shard returns the same set of buckets, some bugs currently exist when a
> range facet contains sub facets that use refinement:
> # the optional {{other}} buckets (before/after/between) are not considered
> during refinement
> # when using the {{include}} option: if {{edge}} is specified, then the
> refinement of all range buckets mistakenly includes the lower bound of the
> range, regardless of whether {{lower}} was specified.
> ----
> #1 occurs because {{FacetRangeMerger extends
> FacetRequestSortedMerger<FacetRange>}} ... however {{FacetRangeMerger}} does
> not override {{getRefinement(...)}} which means only
> {{FacetRequestSortedMerger.buckets}} is evaluated and considered for
> refinement. The additional, special purpose, {{FacetBucket}} instances
> tracked in {{FacetRangeMerger}} are never considered for refinement.
> #2 exists because of a mistaken in the implementation of {{refineBucket}} and
> how it computes the {{start}} value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
