[ https://issues.apache.org/jira/browse/LUCENE-8402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545634#comment-16545634 ]
Jim Ferenczi edited comment on LUCENE-8402 at 7/16/18 7:09 PM: --------------------------------------------------------------- Since it is a deprecated function I don't think we should put it back, [~markh] can you explain the intent of forbidding the reuse of Integers in this test ? It doesn't seem to be required. was (Author: jim.ferenczi): Since it is a deprecated function I don't think we should put it back, [~markh] can you explain the intent of forbidding the reuse of Integers in this test. It doesn't seem to be required. > TestPriorityQueue failures > -------------------------- > > Key: LUCENE-8402 > URL: https://issues.apache.org/jira/browse/LUCENE-8402 > Project: Lucene - Core > Issue Type: Test > Reporter: Jim Ferenczi > Priority: Major > Attachments: LUCENE-8402.patch > > > Elastic CI found a couple of failures in TestPriorityQueue: > {code} > java.lang.AssertionError > at > __randomizedtesting.SeedInfo.seed([7116E1C3DFA51E99:7507110B3E9E9A3]:0) > at > org.apache.lucene.util.TestPriorityQueue$IntegerQueue.lessThan(TestPriorityQueue.java:36) > at > org.apache.lucene.util.TestPriorityQueue$IntegerQueue.lessThan(TestPriorityQueue.java:28) > at org.apache.lucene.util.PriorityQueue.upHeap(PriorityQueue.java:264) > at org.apache.lucene.util.PriorityQueue.add(PriorityQueue.java:141) > at > org.apache.lucene.util.TestPriorityQueue.testIteratorRandom(TestPriorityQueue.java:241) > {code} > It can be reproduced with the following seed: -Dtests.seed=7116E1C3DFA51E99 > It is due to https://issues.apache.org/jira/browse/LUCENE-8345 which removed > the deprecated call to "new Integer" despite the fact that the queue in the > tests (IntegerQueue#lessThan) does not allow to reuse Integers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org