[
https://issues.apache.org/jira/browse/LUCENE-8402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545642#comment-16545642
]
Uwe Schindler commented on LUCENE-8402:
---------------------------------------
Sorry for this. I did not fail in my test, maybe because of randomness.
There are other test that do this ([~mbraun688] added the SuppressWarnings for
the other tests). But this is bogus anyways: Especially it contains an
assertion that the identityHashCode of 2 different objects needs to be
different, which is no requirement by the spec. It can be equal, too - so on
the long term the test could have failed also before!!!
+1 to remove the identity/equals crazyness. We should also review the other
tests that were SuppressWarning'd because of this!
> TestPriorityQueue failures
> --------------------------
>
> Key: LUCENE-8402
> URL: https://issues.apache.org/jira/browse/LUCENE-8402
> Project: Lucene - Core
> Issue Type: Test
> Reporter: Jim Ferenczi
> Priority: Major
> Attachments: LUCENE-8402.patch
>
>
> Elastic CI found a couple of failures in TestPriorityQueue:
> {code}
> java.lang.AssertionError
> at
> __randomizedtesting.SeedInfo.seed([7116E1C3DFA51E99:7507110B3E9E9A3]:0)
> at
> org.apache.lucene.util.TestPriorityQueue$IntegerQueue.lessThan(TestPriorityQueue.java:36)
> at
> org.apache.lucene.util.TestPriorityQueue$IntegerQueue.lessThan(TestPriorityQueue.java:28)
> at org.apache.lucene.util.PriorityQueue.upHeap(PriorityQueue.java:264)
> at org.apache.lucene.util.PriorityQueue.add(PriorityQueue.java:141)
> at
> org.apache.lucene.util.TestPriorityQueue.testIteratorRandom(TestPriorityQueue.java:241)
> {code}
> It can be reproduced with the following seed: -Dtests.seed=7116E1C3DFA51E99
> It is due to https://issues.apache.org/jira/browse/LUCENE-8345 which removed
> the deprecated call to "new Integer" despite the fact that the queue in the
> tests (IntegerQueue#lessThan) does not allow to reuse Integers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
