[ 
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546974#comment-16546974
 ] 

Varun Thacker commented on SOLR-12412:
--------------------------------------

Hi Dat,

The Jira description reads  "When a leader meets some kind of unrecoverable 
exception (ie: CorruptedIndexException). The shard will go into the readable 
state and human has to intervene. In that case, it will be the best if the 
leader gives up its leadership and let other replicas become the leader."

 

But in the test we are asserting this?
{code:java}
assertEquals(leader.getName(), oldLeader.getName());{code}
 

I had a question that I posted yesterday , reposting it for reference :

testOtherReplicasAreNotActive() -> When there are two replicas , where are we 
actually checking if it becomes active or not after it has been started again? 
i.e after this statement should we be checking if it becomes active and fail 
the test?
{code:java}
if (otherReplicaJetty != null) {
// won't be able to do anything here, since this replica can't recovery from 
the leader
otherReplicaJetty.start();
}{code}

> Leader should give up leadership when IndexWriter.tragedy occur
> ---------------------------------------------------------------
>
>                 Key: SOLR-12412
>                 URL: https://issues.apache.org/jira/browse/SOLR-12412
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>            Priority: Major
>             Fix For: master (8.0), 7.5
>
>         Attachments: SOLR-12412.patch, SOLR-12412.patch, 
> jenkins-failure-2325.log
>
>
> When a leader meets some kind of unrecoverable exception (ie: 
> CorruptedIndexException). The shard will go into the readable state and human 
> has to intervene. In that case, it will be the best if the leader gives up 
> its leadership and let other replicas become the leader. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to