[
https://issues.apache.org/jira/browse/LUCENE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547130#comment-16547130
]
Steve Rowe commented on LUCENE-2562:
------------------------------------
[~Tomoko Uchida]: thanks for the pull request. I pulled it into a branch named
{{jira/lucene-2562}}, along with a few fixes and additions, mostly to get {{ant
precommit}} to succeed, which it does not yet do. I haven't tried to run the
code yet :).
A few things I noticed:
# {{validate-source-patterns}} complains about non-static-final loggers:
{noformat}
validate-source-patterns:
[source-patterns] invalid logging pattern [not private static final, uses
static class name]:
lucene/luke/src/java/org/apache/lucene/luke/models/commits/CommitsImpl.java
[source-patterns] invalid logging pattern [not private static final, uses
static class name]:
lucene/luke/src/java/org/apache/lucene/luke/models/documents/DocumentsImpl.java
[source-patterns] invalid logging pattern [not private static final, uses
static class name]:
lucene/luke/src/java/org/apache/lucene/luke/models/search/SearchImpl.java
{noformat}
I fixed a few others like these, but ^^ have ctors that take a logger,
apparently just to be able to turn logging off under testing. Is this really
necessary? Right now I have a nocommit that allows {{ant precommit}} to ignore
these, but it needs to be resolved.
# It should be possible to run Luke from a source checkout, but it's not now.
# I think Luke should be packaged with all other artifacts in Lucene's binary
packages, but currently {{ant package-tgz}} and {{-zip}} don't include
everything (e.g. scripts under {{bin/}}); instead, the build creates a {{.zip}}
file that contains a copy of all the dependencies and the {{bin/}} scripts. I
think we can get rid of this Luke-only distribution, in favor of the Lucene
distribution? I don't like the idea of including the
Luke-with-all-dependencies {{.zip}} in the Lucene distribution, since it will
include two copies of many modules' jars.
# forbidden-apis is very unhappy about classes in {{javafx.\*}} packages, e.g.:
{noformat}
[forbidden-apis] Scanning classes for violations...
[forbidden-apis] Forbidden class/interface use:
javafx.beans.property.BooleanProperty [non-portable or internal runtime class]
[forbidden-apis] in
org.apache.lucene.luke.app.controllers.dto.search.SelectedField
(SelectedField.java, field declaration of 'selected')
[forbidden-apis] Forbidden class/interface use:
javafx.beans.property.SimpleBooleanProperty [non-portable or internal runtime
class]
[forbidden-apis] in
org.apache.lucene.luke.app.controllers.dto.search.SelectedField
(SelectedField.java:29)
[forbidden-apis] Forbidden class/interface use:
javafx.beans.property.SimpleBooleanProperty [non-portable or internal runtime
class]
[...]
{noformat}
[~thetaphi]: do you understand what ^^ is about?
> Make Luke a Lucene/Solr Module
> ------------------------------
>
> Key: LUCENE-2562
> URL: https://issues.apache.org/jira/browse/LUCENE-2562
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Mark Miller
> Priority: Major
> Labels: gsoc2014
> Attachments: LUCENE-2562-Ivy.patch, LUCENE-2562-Ivy.patch,
> LUCENE-2562-Ivy.patch, LUCENE-2562-ivy.patch, LUCENE-2562.patch,
> LUCENE-2562.patch, Luke-ALE-1.png, Luke-ALE-2.png, Luke-ALE-3.png,
> Luke-ALE-4.png, Luke-ALE-5.png, luke-javafx1.png, luke-javafx2.png,
> luke-javafx3.png, luke1.jpg, luke2.jpg, luke3.jpg, lukeALE-documents.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> see
> "RE: Luke - in need of maintainer":
> http://markmail.org/message/m4gsto7giltvrpuf
> "Web-based Luke": http://markmail.org/message/4xwps7p7ifltme5q
> I think it would be great if there was a version of Luke that always worked
> with trunk - and it would also be great if it was easier to match Luke jars
> with Lucene versions.
> While I'd like to get GWT Luke into the mix as well, I think the easiest
> starting point is to straight port Luke to another UI toolkit before
> abstracting out DTO objects that both GWT Luke and Pivot Luke could share.
> I've started slowly converting Luke's use of thinlet to Apache Pivot. I
> haven't/don't have a lot of time for this at the moment, but I've plugged
> away here and there over the past work or two. There is still a *lot* to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
