[
https://issues.apache.org/jira/browse/SOLR-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551898#comment-16551898
]
David Smiley commented on SOLR-12562:
-------------------------------------
Seems reasonable to have RTG use the one in DocStreamer. Though keep in mind
some little differences that matter:
* "isCopyFieldTarget" skipping
* materialize()
You could address both by keeping RTG.toSolrDoc that calls the DocStreamer one
but pre-processes the Lucene Document first to materialize().
I don't know what to make of the SORTED_NUMERIC check supposedly related to
SOLR-10286 which seems an erroneous inclusion in that issue. It's a bit of a
wart on the logic, I don't like it. I wonder what breaks when it's removed,
and if it can be resolved in some other way.
> Remove redundant RealTimeGetCompnent.toSolrDoc and use
> DocStreamer.convertLuceneDocToSolrDoc
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-12562
> URL: https://issues.apache.org/jira/browse/SOLR-12562
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
>
> This code looks really redundant so we should remove one. The one in
> RealTimeGet is the only used locally so my vote is to remove that one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
