Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204404955
--- Diff:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateAliasCmd.java ---
@@ -136,6 +139,16 @@ private Instant parseStart(String str, TimeZone zone) {
return start;
}
+ private void checkPreemptiveCreateWindow(String str) {
+ if (StringUtils.isNotBlank(str)) {
+ try {
+ new DateMathParser().parseMath( "-" + str);
--- End diff --
Woah, the "-" is subtle. If we want to auto-add a "-" then I think it
should be done earlier immediately after reading the parameter in the TRA. I
think that could work? Also, like auto delete age, shouldn't we be consistent
and do the validation in the TRA constructor?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
