[
https://issues.apache.org/jira/browse/LUCENE-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552941#comment-16552941
]
Steve Rowe commented on LUCENE-8412:
------------------------------------
Policeman Jenkins found a reproducing failure of Solr's TestDistributedGrouping
[https://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/4751/]. {{git
bisect}} says that the first bad commit is {{55bfadb}}, committed on this issue:
{noformat}
Checking out Revision 995a902d1ad40860ee082b57e4e47c1be52c856e
(refs/remotes/origin/master)
[...]
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestDistributedGrouping -Dtests.method=test
-Dtests.seed=CE038BEFE9A3BEAD -Dtests.slow=true -Dtests.locale=es-PE
-Dtests.timezone=Etc/GMT+10 -Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] FAILURE 3.57s J0 | TestDistributedGrouping.test <<<
[junit4] > Throwable #1: junit.framework.AssertionFailedError:
.grouped[a_i1].doclist.maxScore:1.0!=null
[junit4] > at
__randomizedtesting.SeedInfo.seed([CE038BEFE9A3BEAD:4657B435475FD355]:0)
[junit4] > at junit.framework.Assert.fail(Assert.java:50)
[junit4] > at
org.apache.solr.BaseDistributedSearchTestCase.compareSolrResponses(BaseDistributedSearchTestCase.java:928)
[junit4] > at
org.apache.solr.BaseDistributedSearchTestCase.compareResponses(BaseDistributedSearchTestCase.java:955)
[junit4] > at
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:613)
[junit4] > at
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:589)
[junit4] > at
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:568)
[junit4] > at
org.apache.solr.TestDistributedGrouping.test(TestDistributedGrouping.java:176)
[junit4] > at
org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsRepeatStatement.callStatement(BaseDistributedSearchTestCase.java:1034)
[junit4] > at
org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:983)
[junit4] > at java.lang.Thread.run(Thread.java:748)
[junit4] 2> NOTE: leaving temporary files on disk at:
/Users/jenkins/workspace/Lucene-Solr-master-MacOSX/solr/build/solr-core/test/J0/temp/solr.TestDistributedGrouping_CE038BEFE9A3BEAD-001
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene70):
{other_tl1=PostingsFormat(name=Direct),
SubjectTerms_mfacet=PostingsFormat(name=Direct), range_facet_l_dv=FST50,
n_l1=Lucene50(blocksize=128),
a_n_tdt=TestBloomFilteredLucenePostings(BloomFilteringPostingsFormat(Lucene50(blocksize=128))),
multiDefault=Lucene50(blocksize=128), intDefault=PostingsFormat(name=Direct),
n_td1=PostingsFormat(name=Direct), n_d1=Lucene50(blocksize=128),
n_f1=PostingsFormat(name=Direct), range_facet_l=Lucene50(blocksize=128),
n_tl1=PostingsFormat(name=Direct),
a_s=TestBloomFilteredLucenePostings(BloomFilteringPostingsFormat(Lucene50(blocksize=128))),
n_tf1=Lucene50(blocksize=128), a_t=Lucene50(blocksize=128), id=FST50,
text=TestBloomFilteredLucenePostings(BloomFilteringPostingsFormat(Lucene50(blocksize=128))),
oddField_s1=PostingsFormat(name=Direct),
a_idv=TestBloomFilteredLucenePostings(BloomFilteringPostingsFormat(Lucene50(blocksize=128))),
timestamp=Lucene50(blocksize=128), n_dt1=PostingsFormat(name=Direct),
a_i1=Lucene50(blocksize=128), b_n_tdt=PostingsFormat(name=Direct), n_ti1=FST50,
rnd_b=FST50,
foo_b=TestBloomFilteredLucenePostings(BloomFilteringPostingsFormat(Lucene50(blocksize=128))),
n_tdt1=PostingsFormat(name=Direct), foo_d=FST50,
id_i1=PostingsFormat(name=Direct), range_facet_i_dv=Lucene50(blocksize=128),
foo_f=TestBloomFilteredLucenePostings(BloomFilteringPostingsFormat(Lucene50(blocksize=128)))},
docValues:{range_facet_l_dv=DocValuesFormat(name=Asserting),
_version_=DocValuesFormat(name=Lucene70),
range_facet_i_dv=DocValuesFormat(name=Lucene70),
intDvoDefault=DocValuesFormat(name=Asserting),
a_idv=DocValuesFormat(name=Direct), timestamp=DocValuesFormat(name=Lucene70)},
maxPointsInLeafNode=1667, maxMBSortInHeap=6.134656462534144,
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@63bfba7e),
locale=es-PE, timezone=Etc/GMT+10
[junit4] 2> NOTE: Mac OS X 10.11.6 x86_64/Oracle Corporation 1.8.0_172
(64-bit)/cpus=3,threads=1,free=5861088,total=213553152
{noformat}
> Remove trackDocScores from TopFieldCollector factory methods
> ------------------------------------------------------------
>
> Key: LUCENE-8412
> URL: https://issues.apache.org/jira/browse/LUCENE-8412
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Priority: Minor
> Fix For: master (8.0)
>
> Attachments: LUCENE-8412.patch
>
>
> Computing scores on top hits is fine, but the current way it is implemented -
> at collection time - requires to read/decode more freqs/norms and compute
> more scores than necessary. It would be more efficient to compute scores of
> top hits as a post-collection step by only advancing the scorer to hits that
> made the top-N list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
