[ 
https://issues.apache.org/jira/browse/LUCENE-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066445#comment-13066445
 ] 

Mark Miller commented on LUCENE-3318:
-------------------------------------

bq. we already have a highlighter that can do this.

I'm hoping that once we have a highlighter than can use this information, that 
can be a much better highlighter - the others can go away. If we can avoid it, 
I don't see why we would want to split effort over 3 different highlighters.

bq. then make that decision in your code when you call 

As I mentioned - I think it's fine to make it so that it has to be explicitly 
asked for in code. But I think it's silly to disallow that just because in some 
cases with huge documents and a giant maxCharsToAnalyze, it can be slow.

bq. and also can sometimes inadvertently create bad defaults.

Defaults can always be bad in some cases - else they wouldn't be called 
defaults - they would just be the way it is. In this case, IMO, it's generally 
been a fine default for the old highlighter - it's the minority of use cases 
that have need something else - all you can expect from a good default.

> Sketch out highlighting based on term positions / position iterators
> --------------------------------------------------------------------
>
>                 Key: LUCENE-3318
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3318
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: modules/highlighter
>    Affects Versions: Positions Branch
>            Reporter: Simon Willnauer
>            Assignee: Mike Sokolov
>             Fix For: Positions Branch
>
>
> Spinn off from LUCENE-2878. Since we have positions on a large number of 
> queries already in the branch is worth looking at highlighting as a real 
> consumer of the API. A prototype is already committed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to