Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205123592
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -190,8 +179,18 @@ private String getLastPath(String path) {
return path.substring(path.lastIndexOf(PATH_SEP_CHAR.charAt(0)) + 1);
}
- private String trimSuffixFromPaths(String path) {
- return path.replaceAll("#\\d|#", "");
+ private String trimIfSingleDoc(String path) {
--- End diff --
Do we really need a set though?
If we trim only the array docs we can then easily figure out at insert time
whether the item is a single doc or an array, optimizing the insert time, and
removing the need for a set
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
