[
https://issues.apache.org/jira/browse/SOLR-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556351#comment-16556351
]
Lucene/Solr QA commented on SOLR-12589:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
3s{color} | {color:blue} The patch file was not named according to SOLR's
naming conventions. Please see
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 3m 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 3m 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 3m 3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 76m 54s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 86m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.autoscaling.MetricTriggerTest |
| | solr.servlet.HttpSolrCallGetCoreTest |
| | solr.handler.admin.SegmentsInfoRequestHandlerTest |
| | solr.cloud.autoscaling.SearchRateTriggerIntegrationTest |
| | solr.cloud.DistribCursorPagingTest |
| | solr.handler.admin.MetricsHandlerTest |
| | solr.handler.admin.MBeansHandlerTest |
| | solr.metrics.reporters.solr.SolrCloudReportersTest |
| | solr.metrics.reporters.solr.SolrShardReporterTest |
| | solr.cloud.autoscaling.TestPolicyCloud |
| | solr.cloud.autoscaling.sim.TestTriggerIntegration |
| | solr.core.RequestHandlersTest |
| | solr.cloud.autoscaling.SearchRateTriggerTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12589 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12933024/SOLR-12589-1.diff |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 71c0bdd |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/151/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/151/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/151/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> metrics name should not contains "/" path seperator while using
> SolrGangliaReporter
> -----------------------------------------------------------------------------------
>
> Key: SOLR-12589
> URL: https://issues.apache.org/jira/browse/SOLR-12589
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: 7.3.1, 7.4, master (8.0)
> Reporter: weizhenyuan
> Priority: Minor
> Fix For: master (8.0)
>
> Attachments: SOLR-12589-1.diff
>
>
> As I was using SolrGangliaReporter, default metrics names will contains
> "/", which is
> offen used in FileSystem as an seperator, than it encounters ERROR cause
> creating
> metrics data file failed, bellow is the Exception in /var/log/messages:
> Jul 25 15:01:37 hb-bp1tg6t003y04p201-001 gmetad: Unable to write meta data
> for metric
> solr.node.QUERY.httpShardHandler.http_//hb-bp1tg6t003y04p201-003.hbase.rds.aliyuncs.com_8983/solr/admin/cores.post.requests.p999
> to RRD
> Jul 25 15:01:37 hb-bp1tg6t003y04p201-001 gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/cores.requestTimes.p999.rrd':
> No such file or directory
> Jul 25 15:01:37 hb-bp1tg6t003y04p201-001 gmetad: Unable to write meta data
> for metric solr.node.ADMIN./admin/cores.requestTimes.p999 to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/collections.requestTimes.min.rrd':
> No such file or directory
> Jul 25 15:01:37 localhost gmetad: Unable to write meta data for metric
> solr.node.ADMIN./admin/collections.requestTimes.min to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/authorization.requestTimes.stddev.rrd':
> No such file or directory
> Jul 25 15:01:37 localhost gmetad: Unable to write meta data for metric
> solr.node.ADMIN./admin/authorization.requestTimes.stddev to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/autoscaling/history.requestTimes.p99.rrd':
> No such file or directory
> Jul 25 15:01:37 localhost gmetad: Unable to write meta data for metric
> solr.node.ADMIN./admin/autoscaling/history.requestTimes.p99 to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.QUERY./admin/autoscaling.timeouts.m1_rate.rrd':
> No such file or directory
> I think the metrics name should be normalized for different reporter，such as
> SolrGangliaReport.
> Some times other normalization is used for other reason，but now，for
> ganglia，It must
> replace the "/" .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
