[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556940#comment-16556940
]
Allen Wittenauer commented on LUCENE-8369:
------------------------------------------
Hi everyone. I was brought here by YETUS-645. Since there were questions
about what went wrong, I re-triggered the test run to see why it was blowing up
since the log files had rolled off.
First, the good news: The patch applied fine. Yetus definitely supports
0-level patches such as generated by IntelliJ; special handling is there to try
to determine what the appropriate patch level should be. If Yetus couldn't
apply the patch, it would have reported the fact explicitly. That's clearly not
the case here.
Now, the bad news: As [~steve_rowe] speculated, Yetus definitely stumbles a bit
when modules are moved or deleted in a patch. It has been a known issue for a
while (YETUS-14 !). I think it's been a low priority to fix since it doesn't
happen that often in a lot of code bases. If you folks need to make sure that
works, let me know and I'll try to prioritize fixing it.
But the badder news: the patch appears to have introduced 4 new javac warnings
in lucene_spatial-extras. Don't let them get lost in that sea of red. ;)
> Remove the spatial module as it is obsolete
> -------------------------------------------
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
