Github user jefferyyuan commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/402#discussion_r205932118
  
    --- Diff: 
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java ---
    @@ -208,14 +208,17 @@ public void handleRequest(SolrQueryRequest req, 
SolrQueryResponse rsp) {
             }
           }
         } catch (Exception e) {
    +      boolean hasTragicException = false;
    --- End diff --
    
    @vthacker 
    Changed the code as you suggested, and like you variable name: isTragic :)
    I checked the code is one of 500 or 404 in LeaderTragicEventTest.java for 
update or commit:
    ```java
       assertThat(se.code(), anyOf(is(500), is(404)));
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to