[ 
https://issues.apache.org/jira/browse/LUCENE-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564252#comment-16564252
 ] 

Adrien Grand commented on LUCENE-8439:
--------------------------------------

Pretty cool. I guess it works well because scores on title dominate the overall 
score?

Should we factor out a DocIdSetIterator implementation similar to ImpactsDISI 
but that would take a Scorer rather than an ImpactsSource to reuse in 
ReqOptSumScorer, DisjunctionMaxScorer and probably other scorers 
(ConstantScoreScorer and CoveringScorer come to mind).

Maybe we should also replace {{boolean needsScores}} with {{ScoreMode 
scoreMode}} so that we would only wrap the approximation when top scores are 
needed rather than all scores?

> DisjunctionMaxScorer should leverage sub scorers' per-block max scores
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-8439
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8439
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Jim Ferenczi
>            Priority: Minor
>         Attachments: LUCENE-8439.patch
>
>
> This issue is similar to https://issues.apache.org/jira/browse/LUCENE-8204 
> but for the DisjunctionMaxScorer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to