[
https://issues.apache.org/jira/browse/SOLR-12590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564343#comment-16564343
]
Cassandra Targett commented on SOLR-12590:
------------------------------------------
I finally got a chance (and remembered!) to review this.
My first reaction when I saw the patch was that I wasn't sure about changing
the name of the page...the new name is more descriptive of the topic discussed,
but there was a reason why all its sibling pages (those under "Configuring
solrconfig.xml") include "SolrConfig" in their names, which was to make it
clear they all referred to settings and parameters in solrconfig.xml (long,
long ago everything there was in a single page). I don't know that makes sense
any more - frankly, I think I was just holding on to it as a historical
artifact that probably means very little to anyone else anymore. So, no
problems on the page name change.
A couple other things about the content specifically:
* I think we're missing a bit of intro into what we mean by resources here -
custom query parser or other type of component jars? files needed by schema
classes? LTR models? - as a paragraph before any of the headings start. Just to
set expectations.
* The first section, "Resources in ConfigSets on ZooKeeper", feels empty to me.
Is it worth mentioning the blob store here (and pointing to it) even though it
can only be used for jars, and also mentioning that some resources could be
uploaded to ZK (and pointing to that doc in
setting-up-an-external-zookeeper-ensemble.adoc)? Upon reading it seems like the
first section is supposed to lead into the second, but people sometimes read
these things in a more piecemeal way - the first section doesn't answer the
question and they're using ZK, so presume there is no answer to the question.
* Essentially it feels like we're setting up two ways of dealing with "large
files" in SolrCloud mode (which was the impetus here): upload them to ZK, or
put them on every node. We should state that explicitly, even if one approach
is only linked to instead of described on the new page.
The page is better, but I think we're missing a couple more ways we can tie all
the options together.
> Improve Solr resource loader coverage in the ref guide
> ------------------------------------------------------
>
> Key: SOLR-12590
> URL: https://issues.apache.org/jira/browse/SOLR-12590
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: documentation
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Priority: Major
> Attachments: SOLR-12590.patch
>
>
> In SolrCloud, storing large resources (e.g. binary machine learned models) on
> the local filesystem should be a viable alternative to increasing ZooKeeper's
> max file size limit (1MB), but there are undocumented complications.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
