[
https://issues.apache.org/jira/browse/LUCENE-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564473#comment-16564473
]
Robert Muir commented on LUCENE-8435:
-------------------------------------
I looked at the changes and code changes look great.
One suggestion: can we add simple unit tests to TestPolygon/TestPolygon2D for
the new methods?
The tests there are pretty easy but go a long way to help development and
detect simple mistakes (versus debugging a hellacious random test, we all know
how that goes). Especially as the query's random test is verified against
Polygon2D behavior (which is the correct separation), it is good to at least
protect against future bugs even though the logic all looks correct to me.
> Add new LatLonShapePolygonQuery
> --------------------------------
>
> Key: LUCENE-8435
> URL: https://issues.apache.org/jira/browse/LUCENE-8435
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Nicholas Knize
> Assignee: Nicholas Knize
> Priority: Major
> Attachments: LUCENE-8435.patch, LUCENE-8435.patch
>
>
> This feature will provide the ability to query indexed {{LatLonShape}} fields
> with an arbitrary polygon. Initial implementation will support {{INTERSECT}}
> queries only and future enhancements will add other relations (e.g.,
> {{CONTAINS}}, {{WITHIN}})
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
