[
https://issues.apache.org/jira/browse/LUCENE-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564926#comment-16564926
]
Adrien Grand commented on LUCENE-8440:
--------------------------------------
Thanks Nick. I think having more javadocs would help but it looks great in
general! Some notes:
- why do we reject closed lines and point to polygons instead, shouldn't it be
possible to index the outline of the polygon using lines rather than the area
of the polygon using a polygon?
- even though I don't think it matters much for performance, it should be easy
to only call encodeLat/encodeLon once per coordinate in the
createIndexableFields methods, so maybe we should do it?
- Line's hashCode and equals don't need to take the min/max lats/lons into
account since they are implicit from the list of coordinates?
- Let's choose either {{double[] Line#getLats}} or {{double getLat(int
index)}} as a way to expose latitudes instead of having two ways to get
latitudes/longitudes out of a line?
> Add support for indexing and searching Line and Point shapes using
> LatLonShape encoding
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-8440
> URL: https://issues.apache.org/jira/browse/LUCENE-8440
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Nicholas Knize
> Priority: Major
> Attachments: LUCENE-8440.patch
>
>
> This feature adds support to {{LatLonShape}} for indexing {{Line}} and
> {{latitude, longitude}} Point types using the 6 dimension Triangle encoding
> in {{LatLonShape}}. Indexed points and lines will be searchable using
> {{LatLonShapeBoundingBoxQuery}} and the new {{LatLonShapePolygonQuery}} in
> LUCENE-8435.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
