Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/428#discussion_r207048145
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
 ---
    @@ -144,15 +153,19 @@ public void init(NamedList args) {
         }
     
         Object defaultTimeZoneParam = args.remove(DEFAULT_TIME_ZONE_PARAM);
    -    DateTimeZone defaultTimeZone = DateTimeZone.UTC;
    +    ZoneId defaultTimeZone = ZoneOffset.UTC;
         if (null != defaultTimeZoneParam) {
    -      defaultTimeZone = 
DateTimeZone.forID(defaultTimeZoneParam.toString());
    +      TimeZone.getTimeZone(defaultTimeZoneParam.toString());
    --- End diff --
    
    This line seems to be needless, since you do nothing with the response?  
And it's the obsolete TimeZone class (we want ZoneId).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to