[
https://issues.apache.org/jira/browse/SOLR-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067187#comment-13067187
]
Martijn van Groningen commented on SOLR-2637:
---------------------------------------------
Thanks Tao. I looked at the patch and it looks good.
They are three things that caught my attention:
* The classes Grouped and GroupField now extend from ArrayList. I think it is
more consistent with other classes (like FacetField, PivotField) if these
classes have a List as a field.
* More meaningful names for Grouped and GroupField classes. Maybe rename
Grouped to GroupResponse and maybe rename GroupField to GroupCommand, since it
might be grouped by function or query.
* And as Ryan said some tests would be great.
For the rest great work!
> Solrj support for Field Collapsing / Grouping query results parsing
> -------------------------------------------------------------------
>
> Key: SOLR-2637
> URL: https://issues.apache.org/jira/browse/SOLR-2637
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 4.0
> Reporter: Tao Cheng
> Priority: Minor
> Labels: features
> Fix For: 4.0
>
> Attachments: SOLR-2637.patch, SOLR-2637.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Patch ready for Field Collapsing query results parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
