[
https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568940#comment-16568940
]
Steve Rowe commented on LUCENE-8060:
------------------------------------
Another separate reproducing failure, of
{{TestIndexWriterReader.testDuringAddIndexes()}}, from
[https://builds.apache.org/job/Lucene-Solr-BadApples-NightlyTests-master/22/];
{{git bisect}} says the first bad commit is also {{99dbe93}} on this issue:
{noformat}
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestIndexWriterReader -Dtests.method=testDuringAddIndexes
-Dtests.seed=195B60C59D5CF096 -Dtests.multiplier=2 -Dtests.nightly=true
-Dtests.slow=true -Dtests.badapples=true
-Dtests.linedocsfile=/home/jenkins/jenkins-slave/workspace/Lucene-Solr-BadApples-NightlyTests-master/test-data/enwiki.random.lines.txt
-Dtests.locale=de-AT -Dtests.timezone=Asia/Yangon -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
[junit4] FAILURE 7.95s J2 | TestIndexWriterReader.testDuringAddIndexes <<<
[junit4] > Throwable #1: java.lang.AssertionError
[junit4] > at
__randomizedtesting.SeedInfo.seed([195B60C59D5CF096:EB820ED6FAF5E600]:0)
[junit4] > at
org.apache.lucene.index.TestIndexWriterReader.testDuringAddIndexes(TestIndexWriterReader.java:772)
[junit4] > at java.lang.Thread.run(Thread.java:748)
[junit4] 1> TEST: now get reader
[junit4] 2> NOTE: leaving temporary files on disk at:
/home/jenkins/jenkins-slave/workspace/Lucene-Solr-BadApples-NightlyTests-master/checkout/lucene/build/core/test/J2/temp/lucene.index.TestIndexWriterReader_195B60C59D5CF096-001
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene70):
{field1=FSTOrd50, indexname=PostingsFormat(name=LuceneFixedGap),
field=PostingsFormat(name=LuceneVarGapFixedInterval),
foo=PostingsFormat(name=LuceneVarGapFixedInterval), id=FSTOrd50,
field3=PostingsFormat(name=LuceneFixedGap),
field2=PostingsFormat(name=LuceneVarGapFixedInterval), field5=FSTOrd50,
field4=TestBloomFilteredLucenePostings(BloomFilteringPostingsFormat(Lucene50(blocksize=128)))},
docValues:{}, maxPointsInLeafNode=258, maxMBSortInHeap=7.974682291420739,
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@7f24c04),
locale=de-AT, timezone=Asia/Yangon
[junit4] 2> NOTE: Linux 4.4.0-112-generic amd64/Oracle Corporation
1.8.0_172 (64-bit)/cpus=4,threads=1,free=176866848,total=520617984
{noformat}
> Enable top-docs collection optimizations by default
> ---------------------------------------------------
>
> Key: LUCENE-8060
> URL: https://issues.apache.org/jira/browse/LUCENE-8060
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Fix For: master (8.0)
>
> Attachments: LUCENE-8060.patch
>
>
> We are getting optimizations when hit counts are not required (sorted
> indexes, MAXSCORE, short-circuiting of phrase queries) but our users won't
> benefit from them unless we disable exact hit counts by default or we require
> them to tell us whether hit counts are required.
> I think making hit counts approximate by default is going to be a bit trappy,
> so I'm rather leaning towards requiring users to tell us explicitly whether
> they need total hit counts. I can think of two ways to do that: either by
> passing a boolean to the IndexSearcher constructor or by adding a boolean to
> all methods that produce TopDocs instances. I like the latter better but I'm
> open to discussion or other ideas?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
