[
https://issues.apache.org/jira/browse/LUCENE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067369#comment-13067369
]
Michael McCandless commented on LUCENE-3282:
--------------------------------------------
I really don't like that this child collector would be buggy (lose results when
involved in a parent query that uses advance); this will cause problems for
users, asking why some hits are missing.
Maybe, instead, we could make a generic wrapper class, taking any Query and a
CollectorProvider, producing a Query, so that all hits "visited" by the
sub-query are sent to the collector, with clear warnings that this collector
will hit false positives (it'll see hits that don't match the top-level Query)
and false negatives (it'll miss hits that did match the wrapped Query)?
How are you using this child collector such that the false positives/negatives
aren't a problem? EG do you know the parent query will never use advance?
> BlockJoinQuery: Allow to add a custom child collector, and customize the
> parent bitset extraction
> -------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3282
> URL: https://issues.apache.org/jira/browse/LUCENE-3282
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/search
> Affects Versions: 3.4, 4.0
> Reporter: Shay Banon
> Attachments: LUCENE-3282.patch, LUCENE-3282.patch
>
>
> It would be nice to allow to add a custom child collector to the
> BlockJoinQuery to be called on every matching doc (so we can do things with
> it, like counts and such). Also, allow to extend BlockJoinQuery to have a
> custom code that converts the filter bitset to an OpenBitSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
