Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/430#discussion_r207909827 --- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java --- @@ -101,83 +102,53 @@ public final static void writeXML(Writer out, String tag, String val) throws IOE } } + /** does NOT escape character data in val or attributes, must already be valid XML */ public final static void writeUnescapedXML(Writer out, String tag, String val, Object... attrs) throws IOException { - writeUnescapedXML(out, tag, (writer1) -> writer1.write(val), attrs); + writeUnescapedAttrXML(out, tag, (writer1) -> writer1.write(val), attrs); } - /** does NOT escape character data in val, must already be valid XML */ - public final static void writeUnescapedXML(Writer out, String tag, Writable val, Object... attrs) throws IOException { + /** does NOT escape character data in attributes, must already be valid XML */ + public final static void writeUnescapedAttrXML(Writer out, String tag, Writable valWritable, Object... attrs) throws IOException { --- End diff -- I changed it to writeElementXML, since when using null values this method's signature conflicts with the existing writeXML.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org