[ https://issues.apache.org/jira/browse/SOLR-12616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571751#comment-16571751 ]
Amrit Sarkar commented on SOLR-12616: ------------------------------------- Thanks Varun for such detailed analysis and feedback on the issue. I see SOLR-11598 resulted in slowness. Benchmarks done at my end also validates an approx 10-18% slowdowns in overall processing of export results. I digged deeper and found the actual function which is slow, but have no idea of reason. Let me share the analysis first: For query Q1, single sort, with {{SingleValueSortDoc}} introduced again, taking 4 mins, while vanila master branch code taking 4:45 mins. I attache a sampler and attaching screenshots for the respective export query executions. If you see screenshots: {{SingleSortValue-2}} and {{DefaultSortValue-2}}, the only significant difference (around 33 secs) between the processing times of respective executions is {{setCurrentValue(docId)}}, which we haven't touched. SingleSortValue: setCurrentValue(docId): *148 secs* DefaultCode: setCurrentValue(docId): *181 secs* I have analyzed the code properly enough to conclude we are not making extra / unnecessary calls for {{setCurrentValue}}, we know the exact line number which is causing the slowness: *ExportWriter:235* > Track down performance slowdowns with ExportWriter > -------------------------------------------------- > > Key: SOLR-12616 > URL: https://issues.apache.org/jira/browse/SOLR-12616 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: streaming expressions > Reporter: Varun Thacker > Priority: Major > Attachments: DefaultCode-1.png, DefaultCode-2.png, SOLR-12616.patch, > SingleSortValue-1.png, SingleSortValue-2.png > > > Just to be clear for users glancing through this Jira : The performance > slowdown is currently on an unreleased version of Solr so no versions are > affected by this. > While doing some benchmarking for SOLR-12572 , I compared the export writers > performance against Solr 7.4 and there seems to be some slowdowns that have > been introduced. Most likely this is because of SOLR-11598 > In an 1 shard 1 replica collection with 25M docs. We issue the following > query > {code:java} > /export?q=*:*&sort=id desc&fl=id{code} > Solr 7.4 took 8:10 , 8:20 and 8:22 in the 3 runs that I did > Master took 10:46 > Amrit's done some more benchmarking so he can fill in with some more numbers > here. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org