[ https://issues.apache.org/jira/browse/SOLR-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576430#comment-16576430 ]
Erick Erickson edited comment on SOLR-12656 at 8/10/18 3:22 PM: ---------------------------------------------------------------- BadAppling the base class was a foo on my part, I'll have to find another way to deal with annotating sub-classes. But that's orthogonal to whether it's preferable to use a different base class, your call of course. It's a little weird though since the in heriteed tests don't seem to run with -Dtests.badapples=true. was (Author: erickerickson): BadAppling the base class was a foo on my part, I'll have to find another way to deal with annotating sub-classes. But that's orthogonal to whether it's preferable to use a different base class, your call of course. > Cut over ShardSplitTest to SolrCloudTestCase > -------------------------------------------- > > Key: SOLR-12656 > URL: https://issues.apache.org/jira/browse/SOLR-12656 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests > Reporter: Shalin Shekhar Mangar > Assignee: Shalin Shekhar Mangar > Priority: Minor > Fix For: master (8.0), 7.5 > > > ShardSplitTest extends BasicDistributedZkTest. When the base class was bad > appled, ShardSplitTest was too. I'll cut over the test to use > SolrCloudTestCase. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org