Uwe Schindler commented on LUCENE-8453:

+1. I will merge it soon!

bq. Slightly off topic, feel free to ignore, but I think Solr example settings 
should be removed from TokenizerFactory/TokenFilterFactory/CharFilterFactory 
documentation. I suppose there may be historical reasons, so I followed the 
convention, but it is not reasonable to add Solr schema examples here. Not XML 
schema examples, but parameter descriptions are needed to each Factory 

There is an issue open already (I think, can't find it now). I agree, the XML 
snippets should go away. Instead we can add some Javadoc tag for this like 
{{@factoryProp name description}}. This is much better. We should also document 
the SPI name of each factory.

> Add example settings to Korean analyzer components' javadocs
> ------------------------------------------------------------
>                 Key: LUCENE-8453
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8453
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/javadocs
>    Affects Versions: 7.4
>            Reporter: Tomoko Uchida
>            Priority: Minor
>             Fix For: master (8.0), 7.5
> Korean analyzer (nori) javadoc needs example schema settings.
> I'll create a patch.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to