Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/435#discussion_r209442225
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
 ---
    @@ -159,8 +170,9 @@ public void init(NamedList args) {
         Collection<String> formatsParam = args.removeConfigArgs(FORMATS_PARAM);
         if (null != formatsParam) {
           for (String value : formatsParam) {
    -        DateTimeFormatter formatter = new 
DateTimeFormatterBuilder().parseCaseInsensitive()
    -            
.appendPattern(value).toFormatter(locale).withZone(defaultTimeZone);
    +        DateTimeFormatter formatter = new 
DateTimeFormatterBuilder().parseLenient().parseCaseInsensitive()
    --- End diff --
    
    I see you're hard-coding leniency and not making it an option.  It's fine, 
I think.  I'm not sure why someone would expressly want it to be strict (would 
want an error), not for an application of parsing like we see here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to