[
https://issues.apache.org/jira/browse/LUCENE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578358#comment-16578358
]
Namgyu Kim edited comment on LUCENE-8449 at 8/13/18 2:47 PM:
-------------------------------------------------------------
Hi, [~jpountz].
I don't know what to do.
I got -1 from test4tests.
But I think that this issue doesn't need a new test because it is a code
optimization.
was (Author: danmuzi):
Hi, [~jpountz].
I wonder what should I do...
I got -1 from test4tests.
But I think that this issue doesn't need a new test because it is a code
optimization.
> Code Optimizations in FieldTermStack
> ------------------------------------
>
> Key: LUCENE-8449
> URL: https://issues.apache.org/jira/browse/LUCENE-8449
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: Namgyu Kim
> Priority: Minor
> Labels: newbie, performance
> Attachments: LUCENE-8449.patch
>
>
> -1) "vector.hasPositions() == false" in FieldTermStack's constructor-
> -can be changed to "*!vector.hasPositions()*"-
>
> 2) "public TermInfo(String, int, int, int, float)" constructor
> can be change to "*TermInfo(String, int, int, int, float)*"
>
> 3) TermInfo's toString method
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder();
> sb.append( text ).append( '(' ).append(startOffset).append ( ','
> ).append( endOffset ).append( ',' ).append( position ).append( ')' );
> return sb.toString();
> }{code}
> This code can be changed to
>
> {code:java}
> public String toString(){
> return text + '(' + startOffset + ',' + endOffset + ',' + position + ')';
> }
> {code}
> this code.
>
>
> 4) TermInfo's equals method
> {code:java}
> public boolean equals(Object obj) {
> ...
> if (position != other.position) {
> return false;
> }
> return true;
> }
> {code}
> This code can be changed to
>
> {code:java}
> public boolean equals(Object obj) {
> ...
> return position == other.position;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
