[ https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584362#comment-16584362 ]
Erick Erickson commented on SOLR-12625: --------------------------------------- Final patch unless there are objections. This patch differs from the last one only in that the test now fires of several threads in order to insure that the document fetcher is not inappropriately re-using the fetch optimizer. Will commit over the weekend. > Combine SolrDocumentFetcher and RetrieveFieldsOptimizer > ------------------------------------------------------- > > Key: SOLR-12625 > URL: https://issues.apache.org/jira/browse/SOLR-12625 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Major > Attachments: SOLR-12625.patch, SOLR-12625.patch, SOLR-12625.patch, > SOLR-12625.patch, SOLR-12625.patch > > > We have SolrDocumentFetcher and RetrieveFieldsOptimizer. The > relationship between the two is unclear at first glance. Using > SolrDocumentFetcher by itself is (or can be) inefficient. > WDYT about combining the two? Is there a good reason you would want to > use SolrDocumentFetcher _instead_ of RetrieveFieldsOptimizer? > Ideally I'd want to be able to write code like: > solrDocumentFetcher.fillDocValuesMostEfficiently > That created an optimizer and "did the right thing". > Assigning to myself to keep track, but if anyone feels motivated feel free to > take it over. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org