[
https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585079#comment-16585079
]
Lucene/Solr QA commented on LUCENE-8458:
----------------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
53s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8458 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12936175/LUCENE-8458.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu
Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / d6e1d4a |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/75/testReport/ |
| modules | C: lucene/core U: lucene/core |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/75/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Carry-over hard-deletes after merge may not adjust soft-delete count
> --------------------------------------------------------------------
>
> Key: LUCENE-8458
> URL: https://issues.apache.org/jira/browse/LUCENE-8458
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Affects Versions: master (8.0), 7.5
> Reporter: Nhat Nguyen
> Priority: Major
> Attachments: LUCENE-8458.patch, test.patch
>
>
> I added a test which can trip PendingDeletetes assertion around 5%.
> This happens because we do not reduce soft-deletes count accordingly when
> carrying over hard-deletes after a merge in IndexWriter#carryOverHardDeletes.
> If the newly merged segment has soft-deleted documents, its PendingDeletes
> requires a segment reader to "transfer" soft-deletes count to hard-deletes
> accordingly.
> testSoftDeleteWhileMergeSurvives(introduced in LUCENE-8293) always passes as
> a segment warmer used in that test forces ReadersAndUpdates to open a new
> segment reader.
> {noformat}
> NOTE: reproduce with: ant test
> -Dtestcase=TestSoftDeletesRetentionMergePolicy
> -Dtests.method=testMixedSoftDeletesAndHardDeletes
> -Dtests.seed=FFED48B49B9F6AA5 -Dtests.slow=true -Dtests.badapples=true
> -Dtests.locale=zh-Hans -Dtests.timezone=Atlantic/South_Georgia
> -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> 8月 19, 2018 12:11:10 上午
> com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
> uncaughtException
> 警告: Uncaught exception in thread: Thread[Lucene Merge Thread
> #0,5,TGRP-TestSoftDeletesRetentionMergePolicy]
> org.apache.lucene.index.MergePolicy$MergeException: java.lang.AssertionError:
> softDeleteCount doesn't match 21 != 19
> at __randomizedtesting.SeedInfo.seed([FFED48B49B9F6AA5]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:704)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:684)
> Caused by: java.lang.AssertionError: softDeleteCount doesn't match 21 != 19
> at
> org.apache.lucene.index.PendingSoftDeletes.onNewReader(PendingSoftDeletes.java:87)
> at
> org.apache.lucene.index.ReadersAndUpdates.getReader(ReadersAndUpdates.java:173)
> at
> org.apache.lucene.index.ReadersAndUpdates.getLatestReader(ReadersAndUpdates.java:237)
> at
> org.apache.lucene.index.PendingSoftDeletes.ensureInitialized(PendingSoftDeletes.java:189)
> at
> org.apache.lucene.index.PendingSoftDeletes.isFullyDeleted(PendingSoftDeletes.java:200)
> at
> org.apache.lucene.index.ReadersAndUpdates.isFullyDeleted(ReadersAndUpdates.java:744)
> at
> org.apache.lucene.index.IndexWriter.isFullyDeleted(IndexWriter.java:5161)
> at
> org.apache.lucene.index.IndexWriter.commitMerge(IndexWriter.java:3926)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4592)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:4058)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:625)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:662)
> NOTE: reproduce with: ant test
> -Dtestcase=TestSoftDeletesRetentionMergePolicy
> -Dtests.method=testMixedSoftDeletesAndHardDeletes
> -Dtests.seed=FFED48B49B9F6AA5 -Dtests.slow=true -Dtests.badapples=true
> -Dtests.locale=zh-Hans -Dtests.timezone=Atlantic/South_Georgia
> -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an
> uncaught exception in thread: Thread[id=16, name=Lucene Merge Thread #0,
> state=RUNNABLE, group=TGRP-TestSoftDeletesRetentionMergePolicy]
> at
> __randomizedtesting.SeedInfo.seed([FFED48B49B9F6AA5:B2667DCCD81812E2]:0)
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.AssertionError: softDeleteCount doesn't match 21 != 19
> at __randomizedtesting.SeedInfo.seed([FFED48B49B9F6AA5]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:704)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:684)
> Caused by: java.lang.AssertionError: softDeleteCount doesn't match 21 != 19
> at
> org.apache.lucene.index.PendingSoftDeletes.onNewReader(PendingSoftDeletes.java:87)
> at
> org.apache.lucene.index.ReadersAndUpdates.getReader(ReadersAndUpdates.java:173)
> at
> org.apache.lucene.index.ReadersAndUpdates.getLatestReader(ReadersAndUpdates.java:237)
> at
> org.apache.lucene.index.PendingSoftDeletes.ensureInitialized(PendingSoftDeletes.java:189)
> at
> org.apache.lucene.index.PendingSoftDeletes.isFullyDeleted(PendingSoftDeletes.java:200)
> at
> org.apache.lucene.index.ReadersAndUpdates.isFullyDeleted(ReadersAndUpdates.java:744)
> at
> org.apache.lucene.index.IndexWriter.isFullyDeleted(IndexWriter.java:5161)
> at
> org.apache.lucene.index.IndexWriter.commitMerge(IndexWriter.java:3926)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4592)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:4058)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:625)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:662)
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
