[
https://issues.apache.org/jira/browse/SOLR-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589082#comment-16589082
]
David Smiley commented on SOLR-12685:
-------------------------------------
bq. This ticket incorporates it, since it should return child docs from the
transaction log in addition to the index,
in case the document was not found there.
Okay; it's debatable as it seems the scope of that issue ought to be both tlog
& index (why do one and not the other?). Any way we can just do it here and
close that one when this is done.
bq. In my opinion adding extra flags only complicates this, and should instead
check if the schema is usable for child docs...
I agree, as you might have guessed based on my feedback on related issues.
bq. Perhaps there is a need though to only get that specific doc, and not the
whole block, even though the document is in the block, perhaps in place
update(I am not very familiar with those features, just to make sure)?
Ehh; I dunno. It hasn't been possible before; we don't have to. It'd be more
work to handle this scenario. I suggest tabling it until some day someone can
express a need for this.
I looked at your rough POC. I see what you're trying to do. Be aware that not
all "SolrIndexSearchers" are created equal... in RTG we need the *realtime*
searcher (thus will see non-committed docs), not req.getSearcher(). I'm also
dubious you needed to change the method signature in RTG to take
SolrQueryRequest; we'll see.
bq. ... which is needed for the atomic update to be merged in the right path
inside the block(AtomicUpdateDocumentMerger#doAdd) ...
Lets not deal with updates in this issue. I think it's separate, perhaps
SOLR-12638.
> RTG should return the whole block if schema is nested
> -----------------------------------------------------
>
> Key: SOLR-12685
> URL: https://issues.apache.org/jira/browse/SOLR-12685
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: mosh
> Priority: Major
> Attachments: SOLR-12638-no-commit.patch
>
>
> Currently Solr's RealTimeGet component return the document if provided a
> docId when consulting the index. For AtomicUpdates for child documents, RTG
> should return the whole block when dealing with a nested schema.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
