[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589744#comment-16589744
]
mosh edited comment on SOLR-12519 at 8/23/18 6:19 AM:
------------------------------------------------------
{quote}Can you investigate [~moshebla]?
{quote}
After further investigation it seems like those tests were failing because
there was no check whether no children matched the childFilter or whether the
parent matched the parentsFilter, causing an assertionError.
I added a couple more conditions to fix this in the patch file
[SOLR-12519-fix-solrj-tests.patch|https://issues.apache.org/jira/secure/attachment/12936767/SOLR-12519-fix-solrj-tests.patch],
which I just uploaded.
was (Author: moshebla):
{quote}Can you investigate [~moshebla]?
{quote}
After further investigation it seems like those tests were failing because
there was no check whether no children matched the childFilter or whether the
parent matched the parentsFilter, causing an assertionError. I added a couple
more conditions to fix this in the patch file
[SOLR-12519-fix-solrj-tests.patch|https://issues.apache.org/jira/secure/attachment/12936767/SOLR-12519-fix-solrj-tests.patch],
which I just uploaded.
> Support Deeply Nested Docs In Child Documents Transformer
> ---------------------------------------------------------
>
> Key: SOLR-12519
> URL: https://issues.apache.org/jira/browse/SOLR-12519
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: mosh
> Priority: Major
> Attachments: SOLR-12519-fix-solrj-tests.patch,
> SOLR-12519-no-commit.patch, SOLR-12519.patch
>
> Time Spent: 23h 10m
> Remaining Estimate: 0h
>
> As discussed in SOLR-12298, to make use of the meta-data fields in
> SOLR-12441, there needs to be a smarter child document transformer, which
> provides the ability to rebuild the original nested documents' structure.
> In addition, I also propose the transformer will also have the ability to
> bring only some of the original hierarchy, to prevent unnecessary block join
> queries. e.g.
> {code} {"a": "b", "c": [ {"e": "f"}, {"e": "g"} , {"h": "i"} ]} {code}
> Incase my query is for all the children of "a:b", which contain the key "e"
> in them, the query will be broken in to two parts:
> 1. The parent query "a:b"
> 2. The child query "e:*".
> If the only children flag is on, the transformer will return the following
> documents:
> {code}[ {"e": "f"}, {"e": "g"} ]{code}
> In case the flag was not turned on(perhaps the default state), the whole
> document hierarchy will be returned, containing only the matching children:
> {code}{"a": "b", "c": [ {"e": "f"}, {"e": "g"} ]{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
