Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212809165
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -392,29 +393,73 @@ public void testPreemptiveCreation() throws Exception
{
CollectionAdminRequest.setAliasProperty(alias)
.addProperty(TimeRoutedAlias.ROUTER_PREEMPTIVE_CREATE_MATH,
"3DAY").process(solrClient);
- Thread.sleep(1000); // a moment to be sure the alias change has taken
effect
-
assertUpdateResponse(add(alias, Collections.singletonList(
sdoc("id", "7", "timestamp_dt", "2017-10-25T23:01:00Z")), //
should cause preemptive creation now
params));
assertUpdateResponse(solrClient.commit(alias));
waitCol("2017-10-27", numShards);
- waitCol("2017-10-28", numShards);
cols = new
CollectionAdminRequest.ListAliases().process(solrClient).getAliasesAsLists().get(alias);
- assertEquals(6,cols.size());
+ assertEquals(5,cols.size()); // only one created in async case
assertNumDocs("2017-10-23", 1);
assertNumDocs("2017-10-24", 1);
assertNumDocs("2017-10-25", 5);
assertNumDocs("2017-10-26", 0);
assertNumDocs("2017-10-27", 0);
+
+ assertUpdateResponse(add(alias, Collections.singletonList(
+ sdoc("id", "8", "timestamp_dt", "2017-10-25T23:01:00Z")), //
should cause preemptive creation now
+ params));
+ assertUpdateResponse(solrClient.commit(alias));
+ waitCol("2017-10-27", numShards);
+ waitCol("2017-10-28", numShards);
+
+ cols = new
CollectionAdminRequest.ListAliases().process(solrClient).getAliasesAsLists().get(alias);
+ assertEquals(6,cols.size()); // Subsequent documents continue to
create up to limit
+ assertNumDocs("2017-10-23", 1);
+ assertNumDocs("2017-10-24", 1);
+ assertNumDocs("2017-10-25", 6);
+ assertNumDocs("2017-10-26", 0);
+ assertNumDocs("2017-10-27", 0);
assertNumDocs("2017-10-28", 0);
QueryResponse resp;
resp = solrClient.query(alias, params(
"q", "*:*",
"rows", "10"));
- assertEquals(7, resp.getResults().getNumFound());
+ assertEquals(8, resp.getResults().getNumFound());
+
+ assertUpdateResponse(add(alias, Arrays.asList(
--- End diff --
Shouldn't we use `addDocsAndCommit` here and the other spots where multiple
docs are added at a time? I know you're passing params but it's empty.
Otherwise, tests look good!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
