GitHub user Apmats opened a pull request:
https://github.com/apache/lucene-solr/pull/442
Fixing an edge case bug when overriding a default PostingsSolrHighligher
Encountered this edge case issue. The impact of this should be limited but
in our case (using a default PostingsSolrHighlighter) this was causing a weird
issue.
The issue here is that, when passing the parameter hl.method=unified, we
enter this switch, and end up in the UNIFIED case. But then we check whether
the preconfigured highlighter is an instance of UnifiedSolrHighlighter.
If the preconfigured highlighter is a PostingsSolrHighlighter, which is
implemented for depracation reasons as a UnifiedSolrHighlighter, then that
highlighter is used instead of a unified one (and effectively the hl.method
parameter is ignored).
In our case, the additional parameters that the PostingsSolrHighlighter
brings with it were causing an issue with highlighting down the line.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Apmats/lucene-solr postings-highlighter-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #442
----
commit bed25f19f605edd9faf8fad65e90a381b16a6afd
Author: amatsagkas <amatsagkas@...>
Date: 2018-08-29T10:00:21Z
Fixing an edge case bug when overriding a default PostingSolrHighlighter
with a unified one through a request parameter
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
