[ https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596383#comment-16596383 ]
David Smiley commented on SOLR-12519: ------------------------------------- This morning I spent some time carefully indenting the document string literal in TestChildDocTransformerHierarchy#generateDocHierarchy and a couple of it's nearby methods so that I could more clearly see what was going on. I also enhanced testParentFilterLimitJSON to test that it does *not* return the "toppings", because they follow the "lonely" stuff which is returned. (a quick try of increasing the limit caused the assertion to fail so I think it's right). I also simplified the limit/match logic, and used ">=" which I think is more clearly correct than "==" since we collect more matches due to needing ancestors. Please close the PR. > Support Deeply Nested Docs In Child Documents Transformer > --------------------------------------------------------- > > Key: SOLR-12519 > URL: https://issues.apache.org/jira/browse/SOLR-12519 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Reporter: mosh > Priority: Major > Attachments: SOLR-12519-fix-solrj-tests.patch, > SOLR-12519-no-commit.patch, SOLR-12519.patch > > Time Spent: 25h 10m > Remaining Estimate: 0h > > As discussed in SOLR-12298, to make use of the meta-data fields in > SOLR-12441, there needs to be a smarter child document transformer, which > provides the ability to rebuild the original nested documents' structure. > In addition, I also propose the transformer will also have the ability to > bring only some of the original hierarchy, to prevent unnecessary block join > queries. e.g. > {code} {"a": "b", "c": [ {"e": "f"}, {"e": "g"} , {"h": "i"} ]} {code} > Incase my query is for all the children of "a:b", which contain the key "e" > in them, the query will be broken in to two parts: > 1. The parent query "a:b" > 2. The child query "e:*". > If the only children flag is on, the transformer will return the following > documents: > {code}[ {"e": "f"}, {"e": "g"} ]{code} > In case the flag was not turned on(perhaps the default state), the whole > document hierarchy will be returned, containing only the matching children: > {code}{"a": "b", "c": [ {"e": "f"}, {"e": "g"} ]{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org