[ 
https://issues.apache.org/jira/browse/LUCENE-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596529#comment-16596529
 ] 

Mike Sokolov edited comment on LUCENE-765 at 8/29/18 4:28 PM:
--------------------------------------------------------------

Ah, OK sorry about that! I had run "ant javadocs" in the core module, and that 
passed OK, just with one warning about future change to html5 format, unrelated 
to my patch. I didn't realize there were additional checks in precommit – I'm 
running that now.

 

UPDATE - `ant precommit` fails its license check for me on a clean master 
checkout with this message:

 

{{check-licenses:}}

[echo] License check under: .../solr

{{BUILD FAILED}}
 {{.../build.xml:117: The following error occurred while executing this line:}}
 {{.../solr/build.xml:364: The following error occurred while executing this 
line:}}
 {{...e/lucene/tools/custom-tasks.xml:62: JAR resource does not exist: 
core/lib/avatica-core-1.9.0.jar}}


was (Author: sokolov):
Ah, OK sorry about that! I had run "ant javadocs" in the core module, and that 
passed OK, just with one warning about future change to html5 format, unrelated 
to my patch. I didn't realize there were additional checks in precommit – I'm 
running that now.

 

UPDATE - `ant precommit` fails its license check for me on a clean master 
checkout with this message:

 

{{check-licenses:}}
{{ [echo] License check under: .../solr}}{{BUILD FAILED}}
{{.../build.xml:117: The following error occurred while executing this line:}}
{{.../solr/build.xml:364: The following error occurred while executing this 
line:}}
{{...e/lucene/tools/custom-tasks.xml:62: JAR resource does not exist: 
core/lib/avatica-core-1.9.0.jar}}

> Index package level javadocs needs content
> ------------------------------------------
>
>                 Key: LUCENE-765
>                 URL: https://issues.apache.org/jira/browse/LUCENE-765
>             Project: Lucene - Core
>          Issue Type: Wish
>          Components: general/javadocs
>            Reporter: Grant Ingersoll
>            Priority: Minor
>              Labels: newdev
>         Attachments: LUCENE-765.patch, LUCENE-765.patch, LUCENE-765.patch, 
> LUCENE-765.patch
>
>
> The org.apache.lucene.index package level javadocs are sorely lacking.  They 
> should be updated to give a summary of the important classes, how indexing 
> works, etc.  Maybe give an overview of how the different writers coordinate.  
> Links to file formats, information on the posting algorithm, etc. would be 
> helpful.
> See the search package javadocs as a sample of the kind of info that could go 
> here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to