[
https://issues.apache.org/jira/browse/SOLR-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12591:
--------------------------------
Priority: Major (was: Minor)
Description:
ParseDateFieldUpdateProcessorFactory should ideally be able to handle the cases
that ExtractionDateUtil does in the "extraction" contrib module. Tests should
be added, ported from patches in SOLR-12561 that enhance TestExtractionDateUtil
to similarly ensure the URP is tested. Additionally the default configSet's
configuration of this URP should be expanded to include the patterns parsed by
the extract contrib.
Once this issue is complete, it should be appropriate to gut date time parsing
out of the "extraction" contrib module – a separate issue (see SOLR-12593).
was:
ParseDateFieldUpdateProcessorFactory should ideally be able to handle the cases
that ExtractionDateUtil does in the "extraction" contrib module. Tests should
be added, ported from patches in SOLR-12561 that enhance TestExtractionDateUtil
to similarly ensure the URP is tested. I think in this issue, I should switch
out Joda time for java.time as well (though leave the complete removal for
SOLR-12586) if it any changes are actually necessary – they probably will be.
Once this issue is complete, it should be appropriate to gut date time parsing
out of the "extraction" contrib module – a separate issue.
I committed a large portion of PR #438 for SOLR-12593 that had to do with
modifying the default configSet to subsume the patterns handled by the
"extraction" contrib. That aspect seemed very distinct and seemed to fit with
this issue well.
I made some further edits from the PR. Instead of {{[ ]d}} or the day in
asctime() I went with {{ppd}} which for practical purposes is the same (tests
pass both ways; "leniency" surely contributing to that) but in principle is
more true to asctime()'s format. I made some other minor renaming and comment
tweaking in the test too. I wanted to put a comment somewhere as to where
these patterns are coming from but didn't know where to do so and I forgot.
> Ensure ParseDateFieldUpdateProcessorFactory can be used instead of
> ExtractionDateUtil
> -------------------------------------------------------------------------------------
>
> Key: SOLR-12591
> URL: https://issues.apache.org/jira/browse/SOLR-12591
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Fix For: master (8.0)
>
> Attachments: SOLR-12591.patch
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> ParseDateFieldUpdateProcessorFactory should ideally be able to handle the
> cases that ExtractionDateUtil does in the "extraction" contrib module. Tests
> should be added, ported from patches in SOLR-12561 that enhance
> TestExtractionDateUtil to similarly ensure the URP is tested. Additionally
> the default configSet's configuration of this URP should be expanded to
> include the patterns parsed by the extract contrib.
> Once this issue is complete, it should be appropriate to gut date time
> parsing out of the "extraction" contrib module – a separate issue (see
> SOLR-12593).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
