Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/443#discussion_r214542325
  
    --- Diff: 
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
 ---
    @@ -91,10 +98,10 @@ private void testChildDoctransformerXML() throws 
Exception {
             "fl", "*,[child parentFilter=\"subject:parentDocument\"]"), test1);
     
         assertQ(req("q", "*:*", "fq", "subject:\"parentDocument\" ",
    -        "fl", "subject,[child parentFilter=\"subject:parentDocument\" 
childFilter=\"title:foo\"]"), test2);
    +        "fl", "id, subject,[child parentFilter=\"subject:parentDocument\" 
childFilter=\"title:foo\"]"), test2);
    --- End diff --
    
    nitpick: remove that extra space after the comma here and in the other 
lines you modified.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to