GitHub user s1monw opened a pull request:
https://github.com/apache/lucene-solr/pull/445
LUCENE-8484: Allow SubReaderWrapper to filter out entire readers
Today we can only wrap readers in SubReaderWrapper but never filter them out
entirely. This causes a invariant for soft-deletes that exposes fully
deleted
segments with SoftDeletesDirectoryReaderWrapper. This change adds an
explcit method
to SubReaderWrapper to filter readers out. A dedicated method is used to
filter instead
of allows null values to make the filter explit rather an implicit action
based on the
return value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1monw/lucene-solr
never_return_fully_deleted_readers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/445.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #445
----
commit 1a51c2525ef864a7c30fdb4c690c65806678e72e
Author: Simon Willnauer <simonw@...>
Date: 2018-09-04T13:09:39Z
LUCENE-8484: Allow SubReaderWrapper to filter out entire readers
Today we can only wrap readers in SubReaderWrapper but never filter them out
entirely. This causes a invariant for soft-deletes that exposes fully
deleted
segments with SoftDeletesDirectoryReaderWrapper. This change adds an
explcit method
to SubReaderWrapper to filter readers out. A dedicated method is used to
filter instead
of allows null values to make the filter explit rather an implicit action
based on the
return value.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
