Github user salsolatragus commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/446#discussion_r215380343
--- Diff: lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java
---
@@ -40,28 +39,40 @@
/** The Similarity implementation. */
final Similarity similarity;
final BooleanQuery query;
-
- final ArrayList<Weight> weights;
+
+ private static class WeightedBooleanClause {
+ BooleanClause clause;
--- End diff --
The code also uses some convenience methods on `BooleanClause`
(`isRequired()`, `isScoring()`, and `isProhibited()`). Those are only checking
the `BooleanCause#Occur`, but these checks are used elsewhere, so we should not
inline them, I suppose. Therefore, we need the entire clause.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
