[ 
https://issues.apache.org/jira/browse/SOLR-12744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604824#comment-16604824
 ] 

Varun Thacker commented on SOLR-12744:
--------------------------------------

There are a couple of other log entries from this class that could be as bad
{code:java}
if (oldIdx > 0) {
  log.info("####### Found new versions added after startup: num=[{}]", oldIdx);
  log.info("###### currentVersions=[{}]",recentVersions);
}

log.info("###### startupVersions=[{}]", startingVersions);{code}
I don't want to simply change this to debug as this can be valuable 
information. Maybe print the first and last version from the list only? 
[~caomanhdat] you worked on PeerSync recently so I'd like to hear your thoughts 
on it

> A high numRecordsToKeep can flood the info log message printing all the 
> versions
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-12744
>                 URL: https://issues.apache.org/jira/browse/SOLR-12744
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Priority: Major
>         Attachments: one_log_line.log
>
>
> I was doing some tests around PeerSync to test how stable is it with the 
> recent fixes.
> This log entry can flood the log printing all the versions that 
> numRecordsToKeep was set to (100k) in my testing
> {code:java}
> log.info("###### startupVersions=[{}]", startingVersions);{code}
> This one log line wrote out almost a 900KB entry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to