[ 
https://issues.apache.org/jira/browse/SOLR-12727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605932#comment-16605932
 ] 

Erick Erickson commented on SOLR-12727:
---------------------------------------

Here's what I have so far. I'll be out today so putting up this preliminary 
patch in case someone who, you know, like, understands ZK wants to take a 
glance.

There are two always-failing tests:

SaslZkACLProviderTest
TestConfigSetsAPIZkFailure

I "fixed" TestConfigSetsAPIZkFailure by the change to ZkTestServer, 
-      zooKeeperServer.shutdown();
+      zooKeeperServer.shutdown(true);

Why did I do that? Well, I looked at the ZooKeeper code for shutdown and saw 
that the entire code path that was erroring out with an NPE could be avoided by 
passing "true". IOW I made a random change that stopped the error without 
having a clue what the consequences are. I don't consider it a fix until I 
understand why the old code did not error out here, but at least it points to 
where to start looking.

If you think the above is a hint that I'd be grateful if someone who 
understands more about ZooKeeper and the ZkTestServer would chime in, you're 
right ;).

[[email protected]][~gchanan] [~tomasflobbe][~anshum] you've touched this 
file in the past, any wisdom?

I'll look more tonight when I get back home.

> Upgrade ZooKeeper dependency to 3.4.13
> --------------------------------------
>
>                 Key: SOLR-12727
>                 URL: https://issues.apache.org/jira/browse/SOLR-12727
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: 7.4
>            Reporter: Shawn Heisey
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-12727.patch
>
>
> Upgrade ZK dependency to 3.4.13.  This fixes ZOOKEEPER-2184 which will make 
> the ZK client re-resolve the server hostnames when a connection fails.  This 
> will fix issues where a failed ZK container is replaced with a new one that 
> has a different IP address and DNS gets updated with the new address.
> Typically these upgrades do not require code changes, but that should be 
> verified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to