[ https://issues.apache.org/jira/browse/LUCENE-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070207#comment-13070207 ]
Mike Sokolov commented on LUCENE-3318: -------------------------------------- Thanks for the pointers; I'll follow up soon. Re: rewriting MultiTermQueries: the code that is in the patch is definitely just a starting point. It has the problems you pointed out Uwe, and also won't work properly in the case where a MTQ is not the top-level query: (foo* AND bar*) eg. This issue is dealt with in the current system by some complex handcrafted logic in WeightedSpanTermExtractor (via QueryScorer), which we are not using here. I hope we can do something simpler, but we do need to walk the query tree cloning MTQs at least - this seems to be what WeightedSpanTermExtractor does. Also - I did run a quick test to check, and it seems that the existing HL may throw a TooManyClauses in the same situation we would here. Perhaps HL consumers expect this? I think I agree that it would be more friendly to catch internally, though - can the consumer recover in any other way? I don't think so. > Sketch out highlighting based on term positions / position iterators > -------------------------------------------------------------------- > > Key: LUCENE-3318 > URL: https://issues.apache.org/jira/browse/LUCENE-3318 > Project: Lucene - Java > Issue Type: Sub-task > Components: modules/highlighter > Affects Versions: Positions Branch > Reporter: Simon Willnauer > Assignee: Mike Sokolov > Fix For: Positions Branch > > Attachments: LUCENE-3318.patch > > > Spinn off from LUCENE-2878. Since we have positions on a large number of > queries already in the branch is worth looking at highlighting as a real > consumer of the API. A prototype is already committed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org