[
https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617570#comment-16617570
]
ASF subversion and git services commented on LUCENE-8503:
---------------------------------------------------------
Commit 44dbfaab19b5845f27d6174071bd3808756ff552 in lucene-solr's branch
refs/heads/master from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=44dbfaa ]
LUCENE-8503: Call #getDelegate instead of direct member access during unwrap
Filter*Reader instances access the member or the delegate directly instead of
calling getDelegate(). In order to track access of the delegate these methods
should call #getDelegat()
> Simplify unwrapping Filter*Reader
> ---------------------------------
>
> Key: LUCENE-8503
> URL: https://issues.apache.org/jira/browse/LUCENE-8503
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 7.5, master (8.0)
> Reporter: Simon Willnauer
> Priority: Major
> Fix For: 7.6, master (8.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Today we have 3 different kinds of FilterIndexReader. While
> FilterDirecotryReader
> and FilterLeafReader are simple to distinguish, FilterCodecReader make
> decision harder
> since now we need instanceof checks to deside which unwrap method we
> should call. This
> adds a simple interface that allows to build generic unwrap methods to
> access the delegat
> of each of the filtering readers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
