[ 
https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619943#comment-16619943
 ] 

Nhat Nguyen commented on LUCENE-8484:
-------------------------------------

[~simonw] This change causes testAddIndicesWithSoftDeletes fail with 
IndexOutOfBoundsException. The patch is a test fix for this.
{noformat}
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestAddIndexes 
-Dtests.method=testAddIndicesWithSoftDeletes -Dtests.seed=B0ECEF265F920F3 
-Dtests.slow=true -Dtests.badapples=true -Dtests.locale=es-PY 
-Dtests.timezone=Pacific/Easter -Dtests.asserts=true -Dtests.file.encoding=UTF8
   [junit4] ERROR   0.09s J1 | TestAddIndexes.testAddIndicesWithSoftDeletes <<<
   [junit4]    > Throwable #1: java.lang.IndexOutOfBoundsException: Index: 1, 
Size: 1
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([B0ECEF265F920F3:275A31B6D0FC04EB]:0)
   [junit4]    >        at java.util.ArrayList.rangeCheck(ArrayList.java:657)
   [junit4]    >        at java.util.ArrayList.get(ArrayList.java:433)
   [junit4]    >        at 
java.util.Collections$UnmodifiableList.get(Collections.java:1309)
   [junit4]    >        at 
org.apache.lucene.index.TestAddIndexes.testAddIndicesWithSoftDeletes(TestAddIndexes.java:1455)
   [junit4]    >        at java.lang.Thread.run(Thread.java:748)
{noformat}
 

> Drop fully deleted reader in SubReaderWrapper
> ---------------------------------------------
>
>                 Key: LUCENE-8484
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8484
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.5, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Minor
>             Fix For: 7.5, master (8.0)
>
>         Attachments: LUCENE-8484.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Today we can only wrap readers in SubReaderWrapper but never filter them out
> entirely. This causes a invariant for soft-deletes that exposes fully deleted
> segments with SoftDeletesDirectoryReaderWrapper. This change drops fully 
> deleted readers after they are wrapped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to