[
https://issues.apache.org/jira/browse/SOLR-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627067#comment-16627067
]
Shalin Shekhar Mangar commented on SOLR-12756:
----------------------------------------------
While trying to debug a test failure in
{{TestPolicyCloud.testCreateCollectionAddShardWithReplicaTypeUsingPolicy}}, I
found that maxShardsPerNode is ignored for add replica API if autoscaling
policy is in effect. The ref guide[1] says:
{code}
Also, if maxShardsPerNode is specified during the time of collection creation,
then both maxShardsPerNode and the policy rules must be satisfied.
{code}
This means that the current behavior is a bug which I already fixed in the
refactoring. I only need to fix the test to set a large maxShardsPerNode (or -1
indicating unlimited).
[1] -
https://lucene.apache.org/solr/guide/7_4/solrcloud-autoscaling-policy-preferences.html
> Refactor Assign and extract replica placement strategies out of it
> ------------------------------------------------------------------
>
> Key: SOLR-12756
> URL: https://issues.apache.org/jira/browse/SOLR-12756
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 7.6, master (8.0)
>
> Attachments: SOLR-12756.patch, SOLR-12756.patch
>
>
> While working on SOLR-12648, I found Assign class to be very complex. Many
> methods have overlapping functionality, differ in side-effects and have
> non-intuitive arguments. We should clean this up and extract replica
> placement strategies out of that class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
