Github user sigram commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/457#discussion_r222587616
--- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java ---
@@ -798,6 +798,12 @@ private void reloadSecurityProperties() {
SecurityConfHandler.SecurityConfig securityConfig =
securityConfHandler.getSecurityConfig(false);
initializeAuthorizationPlugin((Map<String, Object>)
securityConfig.getData().get("authorization"));
initializeAuthenticationPlugin((Map<String, Object>)
securityConfig.getData().get("authentication"));
+ if (authenticationPlugin != null &&
authenticationPlugin.plugin.getMetricRegistry() == null) {
--- End diff --
Is this second check necessary? we know that just after the plugin was
created its metricRegistry is null, it's set only after `initializeMetrics` has
been called.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
